[threeten-dev] TestNG for JTreg

[Stephen Colebourne]

Looks good (not checked every file)

BTW, if/else should always have braces, see AbstractTestPrinterParser.

Stephen


On 27 November 2012 23:38, Xueming Shen <xueming.shen at oracle.com> wrote:
> I'm not sure if this fits your guys taste or not, here is the webrev of
> the changes to the test/javax/time/format, in which I updated all
> (hopefully) unit tests to use the public APIs, while still testing the
> same functionality.
>
> http://cr.openjdk.java.net/~sherman/jdk8_threeten/test_fmt/
>
> -Sherman
>
>
> On 11/26/2012 03:26 PM, Stephen Colebourne wrote:
>>
>> On 26 November 2012 23:20, Xueming Shen<xueming.shen at oracle.com>  wrote:
>>>
>>> Before I change the directory structure and package name. How about the
>>> change suggested in
>>>
>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/test_tz/
>>
>> This all looks pretty fine to me.
>>
>> Its going to be a horrible merge with my other changes I suspect.
>>
>>> I put the tests for ZoneRulesBuilder and TZDBZoneRulesCompiler back
>>> (rename
>>> the TCKZoneRulesBuilder to TestZoneRuleBuilder), though I don't know how
>>> to
>>> deal with them yet. If you insist to keep them there, we might have to
>>> use
>>> reflection, or as an alternative to move those classes into some
>>> implementation
>>> package (we used to move to some into "sun" package"...)
>>
>> The ZoneRulesBuilder is up to you/Oracle as to how it is packaged up.
>> Personally, I think that users should be able to run the TZDB compiler
>> themselves and generate the TZDB input files, thus it needs tests (non
>> TCK).
>> Stephen
>
>