[threeten-dev] Request for review: Chronology name support

Stephen Colebourne scolebourne at joda.org
Thu Feb 14 10:30:19 PST 2013


I'm happy to see this ;-)

- I think the getChronlogyName method should be located within the
ChronoPrinterParser class.

- I'm not sure that the java.text.DateFormat import is needed (haven't
tried compiling without it)

- to fit the rest of the code
 "@param chrono the chronology" ->
 "@param chrono  the chronology, not null"
(two spaces after the parameter and ", not null" on the end

Stephen


On 14 February 2013 04:25, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
> In addition to Chronology name support, I changed the test program to test
> formatting and parsing with Thai digits.
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/310/chronotext/webrev.00/
>
> Thanks,
> Masayoshi
>


More information about the threeten-dev mailing list