[threeten-dev] Request for review: Chronology name support

[Masayoshi Okutsu]

On 2/15/2013 3:30 AM, Stephen Colebourne wrote:
> I'm happy to see this ;-)
>
> - I think the getChronlogyName method should be located within the
> ChronoPrinterParser class.

I put the method outside of ChronoPrinterParser because I thought there 
would be field name support in 310, like ChronoField.MONTH -> "Month". 
But I couldn't find a method to return a field name. So there's no plan 
to support field names?

> - I'm not sure that the java.text.DateFormat import is needed (haven't
> tried compiling without it)
>
> - to fit the rest of the code
>   "@param chrono the chronology" ->
>   "@param chrono  the chronology, not null"
> (two spaces after the parameter and ", not null" on the end

Will fix.

Thanks,
Masayoshi

>
> Stephen
>
>
> On 14 February 2013 04:25, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
>> In addition to Chronology name support, I changed the test program to test
>> formatting and parsing with Thai digits.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~okutsu/310/chronotext/webrev.00/
>>
>> Thanks,
>> Masayoshi
>>