[threeten-dev] Request for review: Chronology name support

[roger riggs]

ok by me tool.

Seeing this code makes me think that ResourceBundle needs a method
that does not throw ResourceException but either returns null or
substitutes a caller provided default value.

   String   getString(String key, String default); {  ...}

It would save on a lot of messy handling by the clients.

(But that's another API.)

Roger

On 2/26/2013 3:00 PM, Stephen Colebourne wrote:
> I'm happy with this change
> Stephen
>
> On 26 February 2013 09:06, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
>> Updated the fix to address Stephen's comments. I've split
>> getChronologyName() to be prepared for field names support.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~okutsu/310/chronotext/webrev.01/
>>
>> Thanks,
>> Masayoshi
>>
>>
>> On 2/15/2013 8:51 AM, Stephen Colebourne wrote:
>>> On 14 February 2013 23:31, Masayoshi Okutsu <masayoshi.okutsu at oracle.com>
>>> wrote:
>>>> On 2/15/2013 3:30 AM, Stephen Colebourne wrote:
>>>>> - I think the getChronlogyName method should be located within the
>>>>> ChronoPrinterParser class.
>>>> I put the method outside of ChronoPrinterParser because I thought there
>>>> would be field name support in 310, like ChronoField.MONTH -> "Month".
>>>> But I
>>>> couldn't find a method to return a field name. So there's no plan to
>>>> support
>>>> field names?
>>> This was an RFE. I'd be happy to see the feature added, but its
>>> Oracle's call not mine.
>>>
>>> Stephen
>>

-- 
Thanks, Roger

Oracle Java Platform Group

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment