[threeten-dev] DateTimeBuilder, cloneable

[Stephen Colebourne]

On 26 February 2013 22:21, Xueming Shen <xueming.shen at oracle.com> wrote:
> Does DTB still need to be "Cloneable"?

No

> Here are two "easy" changes to remove two fb warnings.
>
> (1)We may need the chrono for number formatting later, but obviously it is
> not
> being used now.
> (2) The fbs complains we should use setEntry() instead of
> keyEntry()+getValue(),
> which seems reasonable.
>
> Other "complains" so far appear to be false positive. But the analysis is
> not
> being applied on those classes that uses interface default method classes
> yet.
>
> http://cr.openjdk.java.net/~sherman/jdk8_threeten/findBugs/webrev1/

Fine by me.
Stephen