[threeten-dev] DateTimeBuilder, cloneable

[roger riggs]

Hi,

Those look like reasonable fixes.

DTB does not need to be Cloneable in the current usage pattern.

Roger

On 2/26/2013 5:21 PM, Xueming Shen wrote:
> I'm running FindBugs on the threeten classes, while I'm still trying 
> to figure
> out how to make FindBugs to work with those new JDK8 features (fb throws
> bunch of exception if I use the latest jdk8 as the runtime...)
>
> One of the complains is that "DateTimeBuilder" implements Cloneable 
> but does
> not define or use clone method.
>
> Does DTB still need to be "Cloneable"?
>
> Here are two "easy" changes to remove two fb warnings.
>
> (1)We may need the chrono for number formatting later, but obviously 
> it is not
> being used now.
> (2) The fbs complains we should use setEntry() instead of 
> keyEntry()+getValue(),
> which seems reasonable.
>
> Other "complains" so far appear to be false positive. But the analysis 
> is not
> being applied on those classes that uses interface default method 
> classes yet.
>
> http://cr.openjdk.java.net/~sherman/jdk8_threeten/findBugs/webrev1/
>
> -Sherman