[threeten-dev] Review fixes for issue #192

[Roger Riggs]

The style hasn't settled yet, but to me the declaration looks out of place
if it just starts "default void foo() {}".  I'm of the view that would 
retain
the "public" qualifier even if it was not strictly necessary.  I think 
it is easier to
parse/visualize if a few fixed visual clues are present so that that the 
variable
parts are easier to identify.

Some cleanup will be needed when a style is settled on.

Roger


On 1/2/2013 3:49 PM, Michael Nascimento wrote:
> LGTM.
>
> Unrelated style question: why do we use public for default methods in
> interfaces but don't use public for non-default ones?
>
> Regards,
> Michael
>
> On Wed, Jan 2, 2013 at 6:30 PM, Roger Riggs<Roger.Riggs at oracle.com>  wrote:
>> Please review fixes for https://github.com/ThreeTen/threeten/issues/192
>>
>> Added minimal javadoc to trigger the inclusion of the @throws javadoc
>> in classes that inherit documentation from interfaces.
>>
>> Fixed a couple of typos, missing @Overrides and added TODO's about
>> missing spec's for what fields are needed to make some computations work.
>>
>> http://cr.openjdk.java.net/~rriggs/webrev-exceptions/
>>
>> --
>> Thanks, Roger
>>
>> Oracle Java Platform Group
>>
>> Green Oracle<http://www.oracle.com/commitment>  Oracle is committed to
>> developing practices and products that help protect the environment
>>

-- 
Thanks, Roger

Oracle Java Platform Group

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment