[threeten-dev] [threeten-develop] DisplayNames for field names

Stephen Colebourne scolebourne at joda.org
Wed Mar 6 00:51:26 PST 2013


The default method in TemporalField still needs changing to check for
null locale. Otherwise good to push.
Stephen

On 5 March 2013 22:50, roger riggs <roger.riggs at oracle.com> wrote:
> Hi,
>
>
> On 3/5/2013 8:42 AM, Stephen Colebourne wrote:
>
> Not sure that the aligned-week-of-year should be assigned the "week" key.
>
> Probably not best. For most fields CLDR does not have locale specific data.
>
> Corresponds to the CLDR 'w' week-of-year and would be appropriate
> for IsoFields.WEEK_OF_WEEK_BASED_YEAR and WeekFields.weekOfYear().
>
> Updated:
>
> webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-field-displayname-103/
>
>
> Roger
>
>
> The ChronoField implementation should throw NPE is loclae is null, which
> requires an Objects.requireNotNull and a test.
>
> Otherwise good.
> thanks
> Stephen
>
>
> On 2 March 2013 19:02, roger riggs <roger.riggs at oracle.com> wrote:
>>
>> Hi,
>>
>> Issue #103 requests locale based display names for field names.
>> The data is available and it only needs a
>> TemporalField/ChronoField.getDisplayName
>> method plus a little plumbing.
>>
>> Please review and comment:
>>
>> webrev:
>>    http://cr.openjdk.java.net/~rriggs/webrev-field-displayname-103/
>>
>> javadoc: TemporalField and ChronoField:
>>    http://cr.openjdk.java.net/~rriggs/javadoc-field-displayname-103/
>>
>>
>
>
> ------------------------------------------------------------------------------
> Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
> Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
> endpoint security space. For insight on selecting the right partner to
> tackle endpoint security challenges, access the full report.
> http://p.sf.net/sfu/symantec-dev2dev
> _______________________________________________
> threeten-develop mailing list
> threeten-develop at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>


More information about the threeten-dev mailing list