[threeten-dev] Review request: standalone text support

[roger riggs]

Hi Masayoshi,

The distinction and definition of the difference between format and
standalone forms probably needs to be emphasized, folks are
not going to immediately understand the difference.  I would leave the
tables for M and L separate to highlight the difference.
Perhaps some connection can be made concretely to the TextStyle values; 
We can add more of a description and example later.

The implementation looks good.

Thanks, Roger

On 3/9/2013 7:38 AM, Masayoshi Okutsu wrote:
> I added standalone text support.
>
> - Added 'L' (standalone month names), 'c' (standalone day-of-week 
> names), and 'q' (standalone quarter names).
>
> - Changed 'e' to support text (format day-of-week names) as well. And 
> "ee" is accepted as a valid pattern. This is consistent with the LDML 
> spec. But let me know if this change shouldn't be made.
>
> - "cc" is accepted (as the same pattern as "ee"), which is undefined 
> in the LDML spec.
>
> - 6-letters of 'c' and 'e' are handles as invalid patterns.
>
> - Added standalone day-of-weeknames to FormatData_fi.java for testing 
> purpose. In JRE fi locale, the format day-of-week names are in the 
> standalone form, while the format and standalone names are different 
> in CLDR. We won't be able to change the format names of the JRE fi 
> locale due to the compatibility risk.
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/310/standalonetext/webrev.00
>
> Thanks,
> Masayoshi
>

-- 
Thanks, Roger

Oracle Java Platform Group

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment