[threeten-dev] Review request: standalone text support

[Masayoshi Okutsu]

I changed the multiple lines to M/L, e/c, and Q/q. I've filed a new 
issue #278 for improving descriptions of format/standalone forms.

I confirmed that #244 is no longer reproducible.

Thanks,
Masayoshi

On 3/10/2013 12:39 AM, Stephen Colebourne wrote:
> - In the tables of pattern letters, it might be clearer to change the
> first column to "M/L" to avoid duplicating the rest of the column:
>
>   M       month-of-year               number/text       7; 07; Jul; July; J
>   L       month-of-year (stand-alone) number/text       7; 07; Jul; July; J
> change to
>   M/L     month-of-year               number/text       7; 07; Jul; July; J
>
> with the text describing the stand-alone letter is second
>
> - Looks like issue #244 might also be fixed.
>
> Looks good.
> Stephen
>
>
>
> On 9 March 2013 12:38, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
>> I added standalone text support.
>>
>> - Added 'L' (standalone month names), 'c' (standalone day-of-week names),
>> and 'q' (standalone quarter names).
>>
>> - Changed 'e' to support text (format day-of-week names) as well. And "ee"
>> is accepted as a valid pattern. This is consistent with the LDML spec. But
>> let me know if this change shouldn't be made.
>>
>> - "cc" is accepted (as the same pattern as "ee"), which is undefined in the
>> LDML spec.
>>
>> - 6-letters of 'c' and 'e' are handles as invalid patterns.
>>
>> - Added standalone day-of-weeknames to FormatData_fi.java for testing
>> purpose. In JRE fi locale, the format day-of-week names are in the
>> standalone form, while the format and standalone names are different in
>> CLDR. We won't be able to change the format names of the JRE fi locale due
>> to the compatibility risk.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~okutsu/310/standalonetext/webrev.00
>>
>> Thanks,
>> Masayoshi
>>