[threeten-dev] Please help to review new test cases for java.time.OffsetDateTime

Patrick Zhang patrick.zhang at oracle.com
Fri May 24 01:34:03 PDT 2013


Hi Team,

One simple modification because of below 2 bugs in OffsetDateTime
https://jbs.oracle.com/bugs/browse/JDK-8015293
https://jbs.oracle.com/bugs/browse/JDK-8014939

1. Apply OffsetDateTime.timeLineOrder() to all related compare() test.
2. Add one simple verification for clock.millis(). Since Clock provides 
access to the "current" instant, I guess it may return different value 
for clock.instant().getEpochSecond() and clock.millis() especially if 
test machine is very very slow. The best test strategy is setup one 
minor tolerance between the two values. As one simple checking, here I 
only check it for fixed clock since it always returns same instant.

webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetDateTime/webrev/

result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetDateTime/TCKClock_Fixed.jtr
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/OffsetDateTime/TCKOffsetDateTime.jtr

Regards
Patrick


More information about the threeten-dev mailing list