[threeten-dev] Please help to review new test cases for java.time.temporal.WeekFields

Stephen Colebourne scolebourne at joda.org
Thu May 23 02:57:04 PDT 2013


Looks good to me.
Stephen

On 23 May 2013 05:25, Patrick Zhang <patrick.zhang at oracle.com> wrote:
> Hi Team,
>
> Please help to review test case for  java.time.temporal.WeekFields.
> It is only for equals() and hashCode().
> As description of javadoc, "the comparison is based on the entire state of
> the rules, which is the first day-of-week and minimal days".
>
> Then the test will check 2 included instances in WeekFields class:
> WeekFields.ISOshould be equal with WeekFields.of(DayOfWeek.MONDAY, 4)
> WeekFields.SUNDAY_START should be equal with WeekFields.of(DayOfWeek.SUNDAY,
> 1)
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/temporal/WeekFields/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/temporal/WeekFields/TCKWeekFields.jtr
>
> Regards
> Patrick


More information about the threeten-dev mailing list