[threeten-dev] Please help to review new test cases for java.time.zone.ZoneRules

[Stephen Colebourne]

Fine by me.
Stephen

On 24 May 2013 08:45, Patrick Zhang <patrick.zhang at oracle.com> wrote:
> I have updated the webrev. Change ArrayList to List<?>
>
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/zone/ZoneRules/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/zone/ZoneRules/TCKZoneRules.jtr
>
> Regards
> Patrick
>
>
> On 5/23/13 5:58 PM, Stephen Colebourne wrote:
>>
>> I would prefer to see generics used rather than raw types like ArrayList.
>> Stephen
>>
>> On 23 May 2013 05:43, Patrick Zhang<patrick.zhang at oracle.com>  wrote:
>>>
>>> Hi Team,
>>>
>>> Please help to review new test for java.time.zone.ZoneRules and
>>> ZoneOffsetTransitionRule.
>>>
>>> Description:
>>> Mostly the new added test is used to verify whether below method will
>>> work.
>>> of(ZoneOffset baseStandardOffset,
>>>      ZoneOffset baseWallOffset,
>>>      List<ZoneOffsetTransition>  standardOffsetTransitionList,
>>>      List<ZoneOffsetTransition>  transitionList,
>>>      List<ZoneOffsetTransitionRule>  lastRules)
>>>
>>> In test, we add 1 transition for standardOffset, 3 transitions for
>>> wallOffset at year 2013.
>>> And we add 1 additional transitionRule for wallOffset also, which should
>>> take effect on every year.
>>>
>>> Then we will check nextTransition() on specific time point of year 2013
>>> and
>>> 2014.
>>> The added transitions should take effect on expected time point.
>>>
>>> webrev:
>>>
>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/zone/ZoneRules/webrev/
>>>
>>> test result:
>>>
>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/zone/ZoneRules/TCKZoneRules.jtr
>>>
>>> Regards
>>> Patrick