RFR: Enable array access instrumentation for aarch64
Arthur Eubanks
aeubanks at openjdk.java.net
Thu May 28 17:44:12 UTC 2020
On Thu, 28 May 2020 07:37:16 GMT, eric.1iu <github.com+10482586+erik1iu at openjdk.org> wrote:
> This patch is a subsequent patch of https://github.com/openjdk/tsan/pull/11.
>
> This patch inserts TSAN instrumentation in interpreter at array access
> bytecodes like below:
>
> - aaload, baload, caload, daload, iaload, laload, saload
> - aastore, bastore, castore, dastore, iastore, lastore, sastore
>
> Besides those normal array access bytecodes, some fast bytecodes (e.g.
> fast_icaload) would result in memory access as well. TSAN has disabled
> bytecode rewrite in previous patch. This patch inserts assertions
> in 'fast_xaccess', 'fast_accessfield' and 'fast_icaload' to make sure
> that TSAN would not reach there.
>
>
> [TEST]
> With this patch, all TSAN test cases passed both on x86 and aarch64.
LGTM
Exciting that all the tests pass now! Is there any follow up work after this? (Except of course the monumental task of
upstreaming this into jdk/jdk)
-------------
PR: https://git.openjdk.java.net/tsan/pull/13
More information about the tsan-dev
mailing list