RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v5]
Jiangli Zhou
jiangli at openjdk.org
Wed Jul 24 00:05:40 UTC 2024
On Tue, 23 Jul 2024 00:55:05 GMT, Man Cao <manc at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Change to use log_debug for the pre-existing DEBUG_PRINT.
>
> src/hotspot/share/tsan/tsanOopMap.cpp line 232:
>
>> 230: if (can_move) {
>> 231: // Notify TSan, update occupied region.
>> 232: log_trace(tsan)("__tsan_java_move for [" PTR_FORMAT ", " PTR_FORMAT "] -> [" PTR_FORMAT ", " PTR_FORMAT "]\n",
>
> How about using `log_trace` only for this line, the line in `notify_tsan_for_freed_and_moved_objects` and the line above `__tsan_java_alloc`, and using `log_debug` for all other logging lines?
> I suppose these 3 lines print a lot more messages than other logging lines.
Changed to use log_debug for the pre-existing DEBUG_PRINT calls. The new ones are kept as log_trace. Note, log_trace is higher level (more verbose) than log_debug.
-------------
PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1688932703
More information about the tsan-dev
mailing list