RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v6]

Jiangli Zhou jiangli at openjdk.org
Wed Jul 24 00:32:48 UTC 2024


On Tue, 23 Jul 2024 01:30:21 GMT, Man Cao <manc at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Sort moves for overlapping case only.
>
> src/hotspot/share/tsan/tsanOopMap.cpp line 316:
> 
>> 314:     max_high = MAX2(source_high, target_high);
>> 315: 
>> 316:     moves.sort((2 * n_downward_moves > moves.length()) ?
> 
> Sorting is only needed before calling `handle_overlapping_moves` right? Then it should be in the else branch.

I moved around `moves.sort` a few times for the disjoint and overlapping cases during implementing/testing, due to the `((*dst_meta)) == ((0))` check failures. 

I agree that it only needs sorting for the overlapping case. I just retested with sorting for overlapping case only. All tsan jtreg tests still pass with a release JDK binary.

-------------

PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1688960726


More information about the tsan-dev mailing list