RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v6]
Jiangli Zhou
jiangli at openjdk.org
Wed Jul 24 17:24:31 UTC 2024
On Wed, 24 Jul 2024 03:18:42 GMT, Man Cao <manc at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Sort moves for overlapping case only.
>
> src/hotspot/share/tsan/tsanOopMap.cpp line 284:
>
>> 282:
>> 283: #ifdef ASSERT
>> 284: bool TsanOopMap::exists(oopDesc *addr) {
>
> Is `TsanOopMap::exists` dead code? If so, we can delete it and the `find`, `is_empty` methods in `tsanOppMapTable`.
`TsanOopMap::exists` is used in `SharedRuntime::tsan_oop_unlock`.
> src/hotspot/share/tsan/tsanOopMapTable.hpp line 25:
>
>> 23: */
>> 24:
>> 25: #ifndef SHARE_VM_PRIMS_TSAN_OOPMAPTABLE_HPP
>
> The `VM_PRIMS_` part can be removed and it misses a `TSAN` prefix. It should be `SHARE_TSAN_TSANOOPMAPTABLE_HPP`.
Renamed.
-------------
PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1690174223
PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1690175930
More information about the tsan-dev
mailing list