RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v6]

Jiangli Zhou jiangli at openjdk.org
Wed Jul 24 17:27:45 UTC 2024


On Wed, 24 Jul 2024 01:40:30 GMT, Man Cao <manc at openjdk.org> wrote:

> Could we move this comment about the size field to tsanOopMapTable.hpp? It was in tsanOopMap.hpp before.

This is new.

I think you are referring to the following comment in tsanOopMap.hpp:

"// Oop size must be cached, as it is unsafe to call size() after reference is
// collected."

I added following in tsanOopMapTable.hpp:

"// The oop sizes are saved in the table because we need to
// use the size information when notify TSAN about an freed object."

-------------

PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1690180452


More information about the tsan-dev mailing list