RFR: Reimplement TsanOopMap support using WeakHandle and ResizeableResourceHashtable [v11]
Man Cao
manc at openjdk.org
Sat Jul 27 03:34:44 UTC 2024
On Tue, 23 Jul 2024 01:35:47 GMT, Man Cao <manc at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>>
>> - Use cast_from_oop<T> in various places when coverting oop to different types.
>> - Change TsanOopMapTableKey::_obj to 'oop'.
>> - Change TsanOopMapTableKey::equals to just do `lhs._obj == rhs._obj`.
>
> src/hotspot/share/tsan/tsanOopMap.cpp line 450:
>
>> 448: }
>> 449:
>> 450: // Source and target ranges overlap, the moves need to be ordered to prevent
>
> Can we retain this comment paragraph?
Could we also keep the remaining part of this comment?
"overwhelming majority of the objects move in one direction ... chances are we will be able to order the moves in a few traversals of the moves array"
This is still relevant, i.e. in practice the code does not take O(N^2).
-------------
PR Review Comment: https://git.openjdk.org/tsan/pull/19#discussion_r1693724924
More information about the tsan-dev
mailing list