@ignored tests

[Jonathan Gibbons]

Mea culpa.  I missed that one in my inbox.    I'll respond to it directly.

-- Jon

On 04/12/2013 03:26 PM, Werner Dietl wrote:
> Jon,
>
> is it possible that you don't receive type-annotations-dev emails?
> I replied to your list of test failures:
>
> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2013-April/000806.html
>
> Cheers,
> cu, WMD.
>
> On Fri, Apr 12, 2013 at 2:52 PM, Jonathan Gibbons
> <jonathan.gibbons at oracle.com> wrote:
>> Werner,
>>
>> I've recently posted a list of the test failures in the type-annos forest.
>> If we set aside the javadoc tests for now, are there other test failures
>> we can address?
>>
>> -- Jon
>>
>>
>>
>> On 04/12/2013 02:36 PM, Werner Dietl wrote:
>>> Steve,
>>>
>>> this test case:
>>>
>>>
>>> test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java
>>>
>>> is currently passing for me.
>>> However, it contains comments like:
>>>
>>> "        // Skip failing cases with bug ID's"
>>>
>>> so I assumed that it is skipping some tests that it wants to perform.
>>> So you're not using "@ignore", but to me it seems like there are more
>>> tests that could be enabled.
>>>
>>> You are correct that all our recent changes are in the
>>> type-annotations repositories and not yet in tl or jdk8.
>>> Once all bugs are fixed (or ignored), we should work on promoting these
>>> changes.
>>>
>>> cu, WMD.
>>>
>>>
>>> On Fri, Apr 12, 2013 at 8:40 AM, Steve Sides <steve.sides at oracle.com>
>>> wrote:
>>>> On 4/11/2013 10:12 PM, Werner Dietl wrote:
>>>>> Jon,
>>>>>
>>>>> I enabled that test and it is passing; as I said in an earlier email,
>>>>> I've recently implemented multi-catch type annotations.
>>>>> This test case only contains one part to ignore: adding type
>>>>> annotations to all components; the EG decided to not implement any of
>>>>> the proposals.
>>>>>
>>>>> I think Steve still has a few test-case combinations disabled, but
>>>>> they are all related to repeating type annotations.
>>>> In type-annotation forest non of them are ignored. I realized recently
>>>> that
>>>> the change to put annotations in the code attribute are not yet in jdk8
>>>> forest. Is that right? Can that done soon?  So, most all of the more
>>>> recent
>>>> tests for type-annotations, at least updated versions, are not yet in
>>>> jdk8
>>>> forest.
>>>>
>>>> -steve
>>>>
>>>>> cu, WMD.
>>>>>
>>>>>
>>>>> On Thu, Apr 11, 2013 at 8:54 PM, Jonathan Gibbons
>>>>> <jonathan.gibbons at oracle.com> wrote:
>>>>>> Oh, OK, I see we're down to just one test with @ignore in the
>>>>>> type-annotations/langtools forest.
>>>>>>
>>>>>>
>>>>>> test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java
>>>>>>
>>>>>> Should I remove @ignore from this test, so that this test goes into the
>>>>>> general bucket of tests that need fixing?
>>>>>>
>>>>>> -- Jon
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 04/11/2013 08:49 PM, Jonathan Gibbons wrote:
>>>>>>> Werner, Steve,
>>>>>>>
>>>>>>> We currently have 6 tests related to type annotations in the JDK 8
>>>>>>> forests
>>>>>>> that are currently disabled with an @ignore tag.
>>>>>>>
>>>>>>> What does it take to fix the issues causing these tests to be ignored?
>>>>>>>
>>>>>>> -- Jon
>>>>>>
>>>
>
>