RFR: fix for repeating annotations on type parameter args
Steve Sides
steve.sides at oracle.com
Thu Apr 18 10:30:21 PDT 2013
On 4/18/2013 5:40 AM, Joel Borggrén-Franck wrote:
>> More for Steve: in RepeatingTypeAnnotations.java, what does it mean
>> when "verify" gets "RuntimeVisibleTypeAnnotations:" passed multiple
>> times? Is the first time used for Code and the second for the Method
>> attribute? Should this be handled more explicitly?
>>
>
> That is my interpretaion. First code ("most inner") then method.
I take it you mean the comment,
/**
* Testcases are classes extending {@code RepeatingTypeAnnotations},
* and calling {@link setSrc}, followed by one or more invocations
* of {@link verify} in the body of the constructor.
*/
This is one of Peter Jensen's tests and I'm not certain what use it
would be to call verify twice as he did not write any test cases like that.
However, I can see this way you would only compile the source once and
they run separate sets of checks on the output. I'm not sure that is
necessary since the order of the expected output is not enforced, only
that each line of expected output is present.
I don't think it's necessarily for Code and then Method, although you
could use it that way. It might be improved to enforce order of output
which would give a better insurance that TypeAnnotations are where they
are supposed to be....and enhancement request? :)
-steve
More information about the type-annotations-dev
mailing list