test failures

[Jonathan Gibbons]

On 04/24/2013 09:51 PM, Jonathan Gibbons wrote:
>
> javadoc is believed done, so TestSmoke should be investigated.

So, I'm looking at TestSmoke.   If nothing else, I will shortly push a 
changeset with minor cleanup, including to sort the test cases into 
hex-numerical order.  But in so doing I noticed this:

http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/file/ac33d03e35b8/test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java

>         39  @Target({TYPE_USE})
>         40  @Retention(RetentionPolicy.RUNTIME)
>         41  @interface A {}
>         42  
>         43  @Target({TYPE_USE})
>         44  @Retention(RetentionPolicy.RUNTIME)
>         45  @Documented
>         46  @interface DA {}

Generally, DA is typically used to represent "declaration annotation", 
so it seems strange to see a target of TYPE_USE on an annotation called DA.

Also, it seems that the test cases in this file use numbering with holes 
in, that seems similar but not identical to the enum constants in 
TargetType.  Should we cross-check and.or rationalize these constants?

-- Jon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130425/ba95951b/attachment.html