webrev.03 for type-annotations test

[Werner Dietl]

> While they run correctly as is, I noticed I left these tests a little
> "dirty". :)
> In the process of rearranging them I had added some imports that are not
> needed.
>
> When you have time, this removes those unneeded imports:
> http://cr.openjdk.java.net/~ssides/8005085/webrev.04/

No problem. I just pushed these changes.


> Will you be pulling in the @Repeatable change?
> When that happens, these will need to be updated.

I did pull in jdk8/tl earlier today, which included @Repeatable, if I
saw that correctly.

cu, WMD.

> On 1/16/2013 9:33 PM, Werner Dietl wrote:
>>
>> Hi Steve,
>>
>> thanks for this revised test case! I've just pushed it:
>>
>>
>> http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/b97997dddcf4
>>
>> I pushed my current status, but still have a few outstanding issues.
>> I will write up concrete questions later today or tomorrow.
>>
>> Cheers,
>> cu, WMD.
>>
>> On Tue, Jan 15, 2013 at 3:54 PM, Steve Sides <steve.sides at oracle.com>
>> wrote:
>>>
>>> I've posted a 3rd revision for tests for (repeated)type-annotations on
>>> type
>>> usages. [1]
>>> I updated the webrevComment if you'd like further description of test and
>>> changes. [2]
>>>
>>> Revisions for 1/15/13:
>>> 1. Broke scenarios from 2 into 9 (more fine grained evaluation).
>>> 2. Moved tests which fail to CombinationsTargetTest2.java(so there are
>>> two
>>> test new test files).
>>> 3. Refactored the test helper to reduce duplicated code.
>>> 4. Added sample generated code for each test scenario.
>>> 5. Turned on verbose which shows how many annotations are on each
>>> element.
>>>
>>> [1] http://cr.openjdk.java.net/~ssides/8005085/webrev.03/
>>> [2]
>>> http://cr.openjdk.java.net/~ssides/8005085/webrev.03/webrevComment.txt
>>>
>>> thx,
>>>
>>> steve
>>>
>>
>>
>



-- 
http://www.google.com/profiles/wdietl