Review request for type annotation reflection test

Werner Dietl wdietl at gmail.com
Mon May 20 23:56:31 PDT 2013


I agree with Alex's first two comments. The code duplication for the
test logic and all the different annotation types seems hard to
maintain and update.

cu, WMD.

On Mon, May 20, 2013 at 7:56 PM, Charlie Wang <charlie.wang at oracle.com> wrote:
> Hi,
>   Here's the latest one with a little update:
> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/
>   Please provide comments as soon as possible now that due date is
> approaching.
>
>
> Regards,
> Charlie
>
>
>
> On 2013/5/19 14:10, Charlie Wang wrote:
>
> Hi,
>   Here's test for core reflection support of type-annotations JDK-8013497.
> Please take a look.
>
> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/
>
>
> Regards,
> Charlie
>
>
>
>



-- 
http://www.google.com/profiles/wdietl


More information about the type-annotations-dev mailing list