Review request for type annotation reflection test

Charlie Wang charlie.wang at oracle.com
Tue May 21 03:10:15 PDT 2013


Yes, that make sense. What do you think if I combine the tests? It would 
then have 1 unified data provider and test method, thus solve the 2 
problems.

Regards,
Charlie
On 2013/5/21 14:56, Werner Dietl wrote:
> I agree with Alex's first two comments. The code duplication for the
> test logic and all the different annotation types seems hard to
> maintain and update.
>
> cu, WMD.
>
> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang <charlie.wang at oracle.com> wrote:
>> Hi,
>>    Here's the latest one with a little update:
>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/
>>    Please provide comments as soon as possible now that due date is
>> approaching.
>>
>>
>> Regards,
>> Charlie
>>
>>
>>
>> On 2013/5/19 14:10, Charlie Wang wrote:
>>
>> Hi,
>>    Here's test for core reflection support of type-annotations JDK-8013497.
>> Please take a look.
>>
>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/
>>
>>
>> Regards,
>> Charlie
>>
>>
>>
>>
>
>



More information about the type-annotations-dev mailing list