hg: valhalla/valhalla: [lworld] Withdraw support for the __Flattenable and __NotFlattened field modifiers.

[Srikanth]

On Tuesday 26 June 2018 03:00 PM, Tobias Hartmann wrote:
> Hi Srikanth,
>
> On 26.06.2018 11:21, Srikanth wrote:
>> I am sorry that there is some pain caused by this change, but I believe it is a hit that is
>> preferably taken sooner. Brian and John are of the opinion that the __Flattenable and __NotFlattened
>> modifiers as well as ACC_FLATTENABLE should go as soon as possible.
>>
>> The fix for these broken tests should be simple - to simply delete the __Flattenable keyword from
>> the tests. An instance field whose type is a value class is automatically marked ACC_FLATTENABLE and
>> so the __Flattenable modifier is redundant.
> Yes, I agree with that but my understanding was that we do want to support non-flattened value type
> fields after LW1 (and in fact we already fully support them). How do we continue to test this now
> without a way to declare such fields in the tests?

Hi Tobias,

I did have an express go from Karen to "nuke" these source level 
modifiers before proceeding. But in light of what you say, I'll take a 
look and see what is involved in pushing these under an option instead.

Even with that many of the tests would need "massaging" but I guess it 
won't shut you out from retaining the support for non-flattened value 
type fields.

Srikanth




>
> Thanks,
> Tobias