hg: valhalla/valhalla: [lworld] Withdraw support for the __Flattenable and __NotFlattened field modifiers.

Tobias Hartmann tobias.hartmann at oracle.com
Tue Jun 26 10:02:44 UTC 2018


Hi Srikanth,

On 26.06.2018 11:37, Srikanth wrote:
> I did have an express go from Karen to "nuke" these source level modifiers before proceeding. But in
> light of what you say, I'll take a look and see what is involved in pushing these under an option
> instead.

Thanks for looking into it but we should probably wait for Karen to comment on that. I guess I
missed the discussion/decision of fully removing these modifiers (I thought we just don't want to
support them for LW1).

> Even with that many of the tests would need "massaging" but I guess it won't shut you out from
> retaining the support for non-flattened value type fields.

Yes, I'm fine with modifying the tests, I'm just concerned that without testing the implementation
of non-flattenable fields in the JVM, the code will start to rot very soon.

Thanks,
Tobias



More information about the valhalla-dev mailing list