[lworld] RFR: 8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types [v2]

Srikanth Adayapalam sadayapalam at openjdk.java.net
Mon Aug 10 06:34:11 UTC 2020


On Fri, 7 Aug 2020 23:16:56 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Use ValueBootstrapMethods for Object::hashCode()
>
> David Simms has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change javac not to generate equals/hashCode

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java line 1118:

> 1117:
> 1118:             switch (methodDecl.name.toString()) {
> 1119:                 case "toString":

This switch and the case "toString" should be deleted since it is completely unnecessary. Earlier switch would ensure
that the only way control can flow into this point is when the method concerned is toString() so the check is redundant

-------------

PR: https://git.openjdk.java.net/valhalla/pull/136


More information about the valhalla-dev mailing list