[lworld] RFR: 8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types [v2]

Srikanth Adayapalam sadayapalam at openjdk.java.net
Mon Aug 10 06:41:29 UTC 2020


On Fri, 7 Aug 2020 23:16:56 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Use ValueBootstrapMethods for Object::hashCode()
>
> David Simms has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change javac not to generate equals/hashCode

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java line 1176:

> 1175:                         final List<Type> parameterTypes = methodDecl.sym.type.getParameterTypes();
> 1176:                         switch (parameterTypes.size()) {
> 1177:                             case 0:

I think this switch should be replaced with if (parameterTypes.size() == 0) - with only one case it reads off to use a
switch.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/136


More information about the valhalla-dev mailing list