[lworld] RFR: 8253873: jdi, jvmti, and jdwp tests fail because of unexpected number of interfaces

[Frederic Parain]

On Thu, 1 Oct 2020 20:31:59 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review these changes to fix tier4 and tier5 tests that started failing because injected interface IdentityObject
> is no longer hidden.  Tiers 4 and 5 were run on linux X64, Macosx, and Windows to check that the tests passed.

Harold,

Thank you for fixing this.
Overall, changes look good, but it would be good to update the comments because in the current form, it looks like
there's a mismatch between the comments and the code.

For instance, one test has this comment:
    "// Class1forCheck - 1 direct and 1 indirect interfaces"
but the code has been updated to:
     "  if (iface1list.size() != 3) {"

Someone not familiar with the IdentityObject injection would wonder where this "3" comes from,
as the comment suggest the correct answer is "2".

Regards,

Fred

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/206