[lworld] RFR: 8253873: jdi, jvmti, and jdwp tests fail because of unexpected number of interfaces [v2]

[Harold Seigel]

On Mon, 5 Oct 2020 14:51:21 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253873 jdi, jvmti, and jdwp tests fail because of unexpected number of interfaces
>
> Harold,
> 
> Thank you for fixing this.
> Overall, changes look good, but it would be good to update the comments because in the current form, it looks like
> there's a mismatch between the comments and the code.
> For instance, one test has this comment:
>     "// Class1forCheck - 1 direct and 1 indirect interfaces"
> but the code has been updated to:
>      "  if (iface1list.size() != 3) {"
> 
> Someone not familiar with the IdentityObject injection would wonder where this "3" comes from,
> as the comment suggest the correct answer is "2".
> 
> Regards,
> 
> Fred

Hi Fred,
Thanks for reviewing this change.  Please see updated commit containing additional comments about interface
IdentityObject.

Thanks, Harold

-------------

PR: https://git.openjdk.java.net/valhalla/pull/206