RFR: 8254274: Development to add 'lint' warning for @ValueBased classes [v2]

Roger Riggs rriggs at openjdk.java.net
Wed Oct 28 18:56:00 UTC 2020


On Wed, 28 Oct 2020 08:57:05 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> New javac lint mode (-Xlint:synchronize) to warn about client side as well JDK internal attempts to synchronize on instances of value based classes
>
> Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8254274: Incorporate review comments

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 265:

> 263: 
> 264: javac.opt.Xlint.desc.synchronization=\
> 265:     Warn about synchronization attempts on instances of @ValueBased classes.

The annotation java.internal.ValueBased is purely internal and should not show up in error messages.
The reference to value based should be to the ValueBased.html or just be a lower case value-based.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/237



More information about the valhalla-dev mailing list