RFR: 8254274: Development to add 'lint' warning for @ValueBased classes [v2]

Srikanth Adayapalam sadayapalam at openjdk.java.net
Thu Oct 29 06:04:21 UTC 2020


On Wed, 28 Oct 2020 18:53:02 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8254274: Incorporate review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 265:
> 
>> 263: 
>> 264: javac.opt.Xlint.desc.synchronization=\
>> 265:     Warn about synchronization attempts on instances of @ValueBased classes.
> 
> The annotation java.internal.ValueBased is purely internal and should not show up in error messages.
> The reference to value based should be to the ValueBased.html or just be a lower case value-based.

Good point. Fixed two places to say value-based consistently since this is the language mentioned by ValueBased.html.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/237



More information about the valhalla-dev mailing list