[lworld] RFR: 8253511: [lworld] ClassFileParser does not handle field type mismatch
Harold Seigel
hseigel at openjdk.java.net
Wed Sep 23 16:04:42 UTC 2020
On Wed, 23 Sep 2020 15:42:59 GMT, Frederic Parain <fparain at openjdk.org> wrote:
> Please review this change with replaces an assert with the throwing of an IncompatibleClassChangeError when a
> pre-loaded class is not an inline type. This case was correctly handled for static fields, but not for non-static
> fields. Tested with Mach5, tiers 1 to 3.
>
> Thank you,
>
> Fred
The changes look good! You could add code to the test's exception handler that looks at err.getMessage() to check that
ICE got thrown for the expected reason.
-------------
Marked as reviewed by hseigel (Committer).
PR: https://git.openjdk.java.net/valhalla/pull/195
More information about the valhalla-dev
mailing list