[lworld] RFR: 8253511: [lworld] ClassFileParser does not handle field type mismatch [v2]
Frederic Parain
fparain at openjdk.java.net
Wed Sep 23 17:39:36 UTC 2020
On Wed, 23 Sep 2020 16:01:50 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Verify ICE message in unit test
>
> The changes look good! You could add code to the test's exception handler that looks at err.getMessage() to check that
> ICE got thrown for the expected reason.
Harold,
Thank you for the review, I've updated the test, checking that the error message is the expected one.
Fred
-------------
PR: https://git.openjdk.java.net/valhalla/pull/195
More information about the valhalla-dev
mailing list