[lworld] Integrated: 8278352: [lworld] nmethod assembly snippet in hs_err file misses method name and parameters

Tobias Hartmann thartmann at openjdk.java.net
Wed Dec 8 14:42:31 UTC 2021


On Wed, 8 Dec 2021 13:54:36 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> Some users of `nmethod::maybe_print_nmethod` do not set the `_nmethod_to_print` field and as a result, the method name and arguments are not printed. Now that the `ProtectionDomainSet_lock` has been removed by [JDK-8259242](https://bugs.openjdk.java.net/browse/JDK-8259242) we can also remove the workaround code and move the computation of the calling convention into the print method.
>
> In addition, the regex in the MachCodeFramesInErrorFile test does not properly handle the labels for multiple entry points (for details, see bug report). I adjusted it accordingly.
>
> Best regards,
> Tobias

This pull request has now been integrated.

Changeset: e49b8508
Author:    Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.java.net/valhalla/commit/e49b8508781b3f34e5a62141575dad0ca3798491
Stats:     28 lines in 2 files changed: 1 ins; 18 del; 9 mod

8278352: [lworld] nmethod assembly snippet in hs_err file misses method name and parameters

-------------

PR: https://git.openjdk.java.net/valhalla/pull/590



More information about the valhalla-dev mailing list