[lworld] RFR: 8278352: [lworld] nmethod assembly snippet in hs_err file misses method name and parameters

Tobias Hartmann thartmann at openjdk.java.net
Wed Dec 8 14:00:55 UTC 2021


Some users of `nmethod::maybe_print_nmethod` do not set the `_nmethod_to_print` field and as a result, the method name and arguments are not printed. Now that the `ProtectionDomainSet_lock` has been removed by [JDK-8259242](https://bugs.openjdk.java.net/browse/JDK-8259242) we can also remove the workaround code and move the computation of the calling convention into the print method.

In addition, the regex in the MachCodeFramesInErrorFile test does not properly handle the labels for multiple entry points (for details, see bug report). I adjusted it accordingly.

Best regards,
Tobias

-------------

Commit messages:
- 8278352: [lworld] nmethod assembly snippet in hs_err file misses method name and parameters

Changes: https://git.openjdk.java.net/valhalla/pull/590/files
Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=590&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8278352
Stats: 28 lines in 2 files changed: 1 ins; 18 del; 9 mod
Patch: https://git.openjdk.java.net/valhalla/pull/590.diff
Fetch: git fetch https://git.openjdk.java.net/valhalla pull/590/head:pull/590

PR: https://git.openjdk.java.net/valhalla/pull/590




More information about the valhalla-dev mailing list