[lworld] RFR: 8281618: Add asmtools sources as a test library [v2]
David Simms
dsimms at openjdk.java.net
Mon Feb 14 19:17:40 UTC 2022
On Thu, 10 Feb 2022 23:56:23 GMT, Dan Smith <dlsmith at openjdk.org> wrote:
>> This is mostly a direct copy of the asmtools repo. The one interesting file is JtregDriver, which avoids various complications involved in directly invoking the asmtools 'Main' entry point.
>
> Dan Smith has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge branch 'lworld' into asmtools
> - Fix trailing whitespace
> - Added usage comment
> - Generalize JtregDriver for all asmtools commands
> - Add JtregDriver to provide an entry point that doesn't call System.exit
> - Add asmtools source to test/lib
There is not a good way of adding Valhalla features still in prototyping without having a Valhalla specific copy...looks good
-------------
Marked as reviewed by dsimms (Committer).
PR: https://git.openjdk.java.net/valhalla/pull/646
More information about the valhalla-dev
mailing list