[lworld] Integrated: 8281618: Add asmtools sources as a test library

Dan Smith dlsmith at openjdk.java.net
Mon Feb 14 20:20:39 UTC 2022


On Thu, 10 Feb 2022 21:43:59 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

> Adding the asmtools sources to test/lib to allow for valhalla feature support before the features become standard. (See https://github.com/openjdk/asmtools).
> 
> Example usage: given a source file Foo.jasm in a test directory, the test would typically say:
> 
> `* @build Foo`
> 
> or maybe
> 
> `* @compile Foo.jasm`
> 
> These lines would be replaced with:
> 
> `* @library /test/lib`
> `* @build org.openjdk.asmtools.* org.openjdk.asmtools.jasm.*`
> `* @run driver org.openjdk.asmtools.JtregDriver jasm Foo.jasm`
> 
> I added the JtregDriver class, which takes care of things like making sure the source and class file paths are in the right place (and System.exit doesn't crash jtreg!). Everything else is a straight 'cp -R' from the asmtools repo; I'll follow up with changes to support the Valhalla class file features.

This pull request has now been integrated.

Changeset: dc6036f6
Author:    Dan Smith <dlsmith at openjdk.org>
URL:       https://git.openjdk.java.net/valhalla/commit/dc6036f627813e5605d93be4c89bc8dfa2006bc5
Stats:     27569 lines in 101 files changed: 27569 ins; 0 del; 0 mod

8281618: Add asmtools sources as a test library

Duplicate copy of asmtools that will support Valhalla class file features. Eventually those features will end up in the official asmtools & jtreg, and we can garbage-collect this fork.

Reviewed-by: dsimms

-------------

PR: https://git.openjdk.java.net/valhalla/pull/646



More information about the valhalla-dev mailing list