[lworld] RFR: 8279656: [lworld] Javac diagnostic compiler.err.primitive.class.must.not.implement.cloneable not valid anymore [v2]

[Srikanth Adayapalam]

On Tue, 18 Jan 2022 19:01:33 GMT, Aggelos Biboudis <duke at openjdk.java.net> wrote:

>> Elides the restriction for `Cloneable`.
>
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address reviews

Looks good to me, Congratulations and thanks on your first contribution to Valhalla!

IIRC, the process now for me to /sponsor and for you to /integrate

I am always confused if the order matters, we will know soon ;-)

test/langtools/tools/javac/valhalla/lworld-values/CheckSync.java line 24:

> 22:             notifyAll();
> 23:             finalize();
> 24:         }

Rather than deleting this line, we could have simply commented saying clone is not an error anymore - that would have minimized the changes to the expected out file (we call them the golden files). No need to change now, but in future you can use such techniques to minimize diffs that are painful/tedious to verify.

-------------

Marked as reviewed by sadayapalam (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/603