[lworld] RFR: 8279656: [lworld] Javac diagnostic compiler.err.primitive.class.must.not.implement.cloneable not valid anymore [v2]

[Aggelos Biboudis]

On Wed, 19 Jan 2022 04:28:02 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address reviews
>
> test/langtools/tools/javac/valhalla/lworld-values/CheckSync.java line 24:
> 
>> 22:             notifyAll();
>> 23:             finalize();
>> 24:         }
> 
> Rather than deleting this line, we could have simply commented saying clone is not an error anymore - that would have minimized the changes to the expected out file (we call them the golden files). No need to change now, but in future you can use such techniques to minimize diffs that are painful/tedious to verify.

Thank you for the recommendation!

-------------

PR: https://git.openjdk.java.net/valhalla/pull/603