[lworld] RFR: 8280382: [lworld] JCWithField AST node support should evolve to work with value classes

Aggelos Biboudis duke at openjdk.java.net
Fri Jan 28 10:39:35 UTC 2022


On Fri, 28 Jan 2022 07:06:51 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> This PR ports basic `withField` tests from lworld-values to value-objects and extending some areas of code to support `withField` within value classes.
>> 
>> Nitpicking and a note: one of the error messages is now `compiler.err.primitive.or.value.class.instance.field.expected.here`. Would you propose to disambiguate further depending whether we are inside a `primitive` or a `value` class?
>
> Change value to primitive class instance in one test in lworld-values directory

Thanks for the review @sadayapalam! 🎉  will address the comments

-------------

PR: https://git.openjdk.java.net/valhalla/pull/621



More information about the valhalla-dev mailing list