[lworld] RFR: 8280382: [lworld] JCWithField AST node support should evolve to work with value classes [v2]

Aggelos Biboudis duke at openjdk.java.net
Fri Jan 28 13:16:42 UTC 2022


> This PR ports basic `withField` tests from lworld-values to value-objects and extending some areas of code to support `withField` within value classes.
> 
> Nitpicking and a note: one of the error messages is now `compiler.err.primitive.or.value.class.instance.field.expected.here`. Would you propose to disambiguate further depending whether we are inside a `primitive` or a `value` class?

Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:

  Address review

-------------

Changes:
  - all: https://git.openjdk.java.net/valhalla/pull/621/files
  - new: https://git.openjdk.java.net/valhalla/pull/621/files/e0f302f2..5aa7e600

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=valhalla&pr=621&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=valhalla&pr=621&range=00-01

  Stats: 107 lines in 12 files changed: 38 ins; 49 del; 20 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/621.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/621/head:pull/621

PR: https://git.openjdk.java.net/valhalla/pull/621



More information about the valhalla-dev mailing list