[lworld] RFR: 8280382: [lworld] JCWithField AST node support should evolve to work with value classes [v3]

Aggelos Biboudis duke at openjdk.java.net
Fri Jan 28 15:27:47 UTC 2022


> This PR ports basic `withField` tests from lworld-values to value-objects and extending some areas of code to support `withField` within value classes.
> 
> Nitpicking and a note: one of the error messages is now `compiler.err.primitive.or.value.class.instance.field.expected.here`. Would you propose to disambiguate further depending whether we are inside a `primitive` or a `value` class?

Aggelos Biboudis has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Address review

-------------

Changes:
  - all: https://git.openjdk.java.net/valhalla/pull/621/files
  - new: https://git.openjdk.java.net/valhalla/pull/621/files/5aa7e600..30b9b62d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=valhalla&pr=621&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=valhalla&pr=621&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/621.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/621/head:pull/621

PR: https://git.openjdk.java.net/valhalla/pull/621



More information about the valhalla-dev mailing list