[lworld] RFR: 8280382: [lworld] JCWithField AST node support should evolve to work with value classes [v2]

Aggelos Biboudis duke at openjdk.java.net
Fri Jan 28 15:27:51 UTC 2022


On Fri, 28 Jan 2022 13:47:08 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1335:
> 
>> 1333:             if (tree.init != null) {
>> 1334:                 if ((v.flags_field & FINAL) == 0 || ((v.flags_field & STATIC) == 0 && (v.owner.isPrimitiveClass() || v.owner.isValueClass())) ||
>> 1335:                     !memberEnter.needsLazyConstValue(tree.init)) {
> 
> There is still one instanceof isPrimitiveClass() || isValueClass() left in

Oups. Good catch.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/621



More information about the valhalla-dev mailing list