RFR: addressing review comments [v2]

[Maurizio Cimadamore]

On Thu, 3 Mar 2022 04:31:12 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Fixing a compiler crash plus other review comments from Maurizio
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   additional test and bug fix

My suggestion is to fix the crash first, and then file another PR for adding support for nested unchecked null warnings, as that is probably a biggie feature.

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 1754:

> 1752:                     TypeVar other = (TypeVar)s;
> 1753:                     if (allowUniversalTVars && t.isValueProjection() != other.isValueProjection() && t.tsym == other.tsym) {
> 1754:                         if (warnStack.head != null) {

I suppose this is the fix for the crash?

-------------

PR: https://git.openjdk.java.net/valhalla/pull/663