RFR: addressing review comments [v2]

Vicente Romero vromero at openjdk.java.net
Thu Mar 3 14:06:31 UTC 2022


On Thu, 3 Mar 2022 10:46:07 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> My suggestion is to fix the crash first, and then file another PR for adding support for nested unchecked null warnings, as that is probably a biggie feature.

sounds good I will do that

> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 1754:
> 
>> 1752:                     TypeVar other = (TypeVar)s;
>> 1753:                     if (allowUniversalTVars && t.isValueProjection() != other.isValueProjection() && t.tsym == other.tsym) {
>> 1754:                         if (warnStack.head != null) {
> 
> I suppose this is the fix for the crash?

correct

-------------

PR: https://git.openjdk.java.net/valhalla/pull/663



More information about the valhalla-dev mailing list