[lworld] RFR: 8287330: (valhalla) Better modeling of access flags in core reflection

liach duke at openjdk.java.net
Wed May 25 21:45:11 UTC 2022


On Wed, 25 May 2022 16:57:38 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Import, verbatim, the new API for access flags to Valhalla;  (Not in mainline until jdk 20).
> The API is unmodified from the mainline version. [Mainline Review openjdk/jdk/7445](https://git.openjdk.java.net/jdk/pull/7445) 
> 
> The Valhalla modifiers will be added in the new AccessFlags class in a subsequent PR.
> The existing Modifiers class will not include Valhalla specific modifiers.

src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 167:

> 165:              * but is optional in the dynamic phase, during execution.
> 166:              */
> 167:             STATIC(AccessFlag.STATIC.mask()),

This one should have been `AccessFlag.STATIC_PHASE`

-------------

PR: https://git.openjdk.java.net/valhalla/pull/697



More information about the valhalla-dev mailing list