[lworld] RFR: 8287330: (valhalla) Better modeling of access flags in core reflection

Roger Riggs rriggs at openjdk.java.net
Wed May 25 22:38:08 UTC 2022


On Wed, 25 May 2022 21:41:34 GMT, liach <duke at openjdk.java.net> wrote:

>> Import, verbatim, the new API for access flags to Valhalla;  (Not in mainline until jdk 20).
>> The API is unmodified from the mainline version. [Mainline Review openjdk/jdk/7445](https://git.openjdk.java.net/jdk/pull/7445) 
>> 
>> The Valhalla modifiers will be added in the new AccessFlags class in a subsequent PR.
>> The existing Modifiers class will not include Valhalla specific modifiers.
>
> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 167:
> 
>> 165:              * but is optional in the dynamic phase, during execution.
>> 166:              */
>> 167:             STATIC(AccessFlag.STATIC.mask()),
> 
> This one should have been `AccessFlag.STATIC_PHASE`

ok, fix later

-------------

PR: https://git.openjdk.java.net/valhalla/pull/697



More information about the valhalla-dev mailing list