[lworld] RFR: 8288135: [lworld] Implement HotSpot flag -XX:+EnablePrimitiveClasses [v10]

[David Simms]

On Mon, 3 Oct 2022 14:13:13 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> David Simms has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
>> 
>>  - Merge branch 'lworld' into 8288135
>>  - Extra assertion info for tracking spurious issue
>>  - supports_inline_types() refers to classfile and is separate from Enable flags
>>  - Further testing explicity using flags
>>  - Disable EnablePrimitiveClasses by default
>>  - Explictly flag more tests
>>  - Merge branch 'lworld' into 8288135
>>  - jdk_valhalla tests
>>  - Merge branch 'lworld' into 8288135
>>  - Further test fixes
>>  - ... and 12 more: https://git.openjdk.org/valhalla/compare/951544ff...1853e0c6
>
> src/hotspot/share/runtime/arguments.cpp line 3036:
> 
>> 3034:   }
>> 3035: 
>> 3036:   if (!EnableValhalla) {
> 
> Why silently change the option when -XX:+EnablePrimitiveClass is specified without -XX:+EnableValhalla? Wouldn't be more informative to throw an error message?

Agreed, added error message

-------------

PR: https://git.openjdk.org/valhalla/pull/727